fix: signingKey should not be part of the computed hash
#696
Conversation
In some flows it `signingKey` is serialized to `null` and messes up the signature.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mkleene, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides a critical fix to the hashing mechanism for Assertion objects. It ensures that the signingKey property is no longer considered when generating the hash, resolving a bug where its null serialization could inadvertently corrupt the signature. This change improves the robustness and correctness of signature generation in certain flows.
Highlights
- Hashing Logic Fix: Modified the
hashfunction inlib/tdf3/src/assertions.tsto exclude thesigningKeyproperty from the canonicalization process. This addresses an issue where anullsigningKeycould incorrectly alter the computed hash, leading to signature validation failures.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
Signed-off-by: Morgan Kleene <[email protected]>
Signed-off-by: Morgan Kleene <[email protected]>
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
Signed-off-by: Morgan Kleene <[email protected]>
|
In some flows it appears that
signingKeyis set and then serialized tonulland messes up the signature.